01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.JselException;
28: import com.pavelvlasov.jsel.Method;
29: import com.pavelvlasov.jsel.VariableDefinition;
30: import com.pavelvlasov.jsel.expressions.Dot;
31: import com.pavelvlasov.jsel.expressions.Ident;
32: import com.pavelvlasov.jsel.expressions.This;
33: import com.pavelvlasov.review.SourceMarker;
34:
35: /**
36: * ER-088
37: * Avoid using an object to access "static" fields or methods
38: * @author Pavel Vlasov
39: * @version $Revision: 1.3 $
40: */
41: public class AccessToStaticMembersRule extends InspectorBase {
42:
43: /**
44: * The modifier static
45: */
46: private static final String STATIC = "static";
47:
48: /**
49: * Reviews if the two side of the dot violates against the rule.
50: * (non static on the left and static on the right.)
51: *
52: * @param dot the dot to be reviewed
53: */
54: public void visit(Dot dot) {
55: Object dot1 = dot.getOperand(1);
56: if (dot1 instanceof Ident) {
57: try {
58: Object provider = ((Ident) dot1).getProvider();
59: boolean isStatic = false;
60: if (provider instanceof Method) {
61: if (((Method) provider).getModifiers().contains(
62: STATIC)) {
63: isStatic = true;
64: }
65: } else if (provider instanceof VariableDefinition) {
66: if (((VariableDefinition) provider).getModifiers()
67: .contains(STATIC)) {
68: isStatic = true;
69: }
70: }
71:
72: if (isStatic) {
73: Object dot0 = dot.getOperand(0);
74: Ident user = null;
75: if (dot0 instanceof This) {
76: context.reportViolation((SourceMarker) dot1);
77: } else if (dot0 instanceof Ident) {
78: user = (Ident) dot0;
79: } else if (dot0 instanceof Dot) {
80: user = (Ident) ((Dot) dot0).getOperand(1);
81: }
82: if (user != null) {
83: provider = user.getProvider();
84: if (provider instanceof VariableDefinition) {
85: if (!((VariableDefinition) provider)
86: .getModifiers().contains(STATIC)) {
87: context
88: .reportViolation((SourceMarker) dot1);
89: }
90: }
91: }
92: }
93: } catch (JselException e) {
94: context.warn((SourceMarker) dot, e);
95: }
96: }
97: }
98: }
|