01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import java.util.Iterator;
26:
27: import org.hammurapi.InspectorBase;
28:
29: import com.pavelvlasov.jsel.expressions.Equal;
30: import com.pavelvlasov.jsel.expressions.Expression;
31: import com.pavelvlasov.jsel.expressions.False;
32: import com.pavelvlasov.jsel.expressions.NotEqual;
33: import com.pavelvlasov.jsel.expressions.True;
34: import com.pavelvlasov.review.SourceMarker;
35:
36: /**
37: * ER-046
38: * Avoid equality operations on 'true' and 'false' boolean literals.
39: * @author Pavel Vlasov
40: * @version $Revision: 1.2 $
41: */
42: public class BooleanEqualityRule extends InspectorBase {
43:
44: public void visit(Equal element) {
45: check(element);
46: }
47:
48: public void visit(NotEqual element) {
49: check(element);
50: }
51:
52: /**
53: * @param element
54: */
55: private void check(Expression element) {
56: Iterator it = element.getOperands().iterator();
57: while (it.hasNext()) {
58: Object o = it.next();
59: if (o instanceof True || o instanceof False) {
60: context.reportViolation((SourceMarker) o);
61: }
62: }
63: }
64: }
|