01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import java.util.Iterator;
26:
27: import org.hammurapi.InspectorBase;
28:
29: import com.pavelvlasov.jsel.Class;
30: import com.pavelvlasov.jsel.Field;
31: import com.pavelvlasov.jsel.JselException;
32: import com.pavelvlasov.jsel.Method;
33: import com.pavelvlasov.review.SourceMarker;
34:
35: /**
36: * ER-078
37: * Do not define 'finalize ()' method in bean classes
38: * @author Pavel Vlasov
39: * @version $Revision: 1.2 $
40: */
41: public class DefineFinalizeInEjbRule extends InspectorBase {
42: public void visit(Class clazz) {
43: try {
44: if (clazz.isKindOf("javax.ejb.EnterpriseBean")) {
45: Iterator it = clazz.getFields().iterator();
46: while (it.hasNext()) {
47: Field f = (Field) it.next();
48: if (f instanceof Method
49: && "finalize"
50: .equals(((Method) f).getName())
51: && ((Method) f).getParameters().isEmpty()) {
52: context.reportViolation(f);
53: }
54: }
55: }
56: } catch (JselException e) {
57: context.warn((SourceMarker) clazz, e);
58: }
59: }
60: }
|