01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.JselException;
28: import com.pavelvlasov.jsel.TypeSpecification;
29: import com.pavelvlasov.jsel.expressions.Expression;
30: import com.pavelvlasov.jsel.expressions.NewObject;
31: import com.pavelvlasov.review.SourceMarker;
32:
33: /**
34: * Packages should be imported in alphabetical order
35: * @author Pavel Vlasov
36: * @version $Revision: 1.3 $
37: */
38: public class DoNotUseNewForStringsRule extends InspectorBase {
39:
40: public void visit(NewObject newObject) {
41: try {
42: if (newObject.getTypeSpecification().isKindOf(
43: "java.lang.String")) {
44: if (newObject.getParameters().size() == 0) {
45: context.reportViolation((SourceMarker) newObject);
46: } else if (newObject.getParameters().size() == 1) {
47: TypeSpecification pt = ((Expression) newObject
48: .getParameters().get(0))
49: .getTypeSpecification();
50: if (pt.isKindOf("java.lang.String")
51: || pt.isKindOf("java.lang.StringBuffer")) {
52: context
53: .reportViolation((SourceMarker) newObject);
54: }
55: }
56: }
57: } catch (JselException e) {
58: context.warn((SourceMarker) newObject, e);
59: }
60: }
61: }
|