01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import java.util.Iterator;
26:
27: import org.hammurapi.InspectorBase;
28:
29: import com.pavelvlasov.jsel.JselException;
30: import com.pavelvlasov.jsel.Method;
31:
32: /**
33: * ER-074
34: * Declare finder methods "public" and neither "final" nor "static"
35: * @author Pavel Vlasov
36: * @version $Revision: 1.2 $
37: */
38: public class FinderModifiersRule extends InspectorBase {
39:
40: public void visit(com.pavelvlasov.jsel.Class clazz) {
41: try {
42: if (clazz.isKindOf("javax.ejb.EnterpriseBean")) {
43: Iterator it = clazz.getFields().iterator();
44: while (it.hasNext()) {
45: Object o = it.next();
46: if (o instanceof Method) {
47: Method method = (Method) o;
48: if (method.getName().startsWith("ejbFind")) {
49: if (!method.getModifiers().contains(
50: "public")) {
51: context.reportViolation(method);
52: }
53: if (method.getModifiers().contains("final")) {
54: context.reportViolation(method);
55: }
56: if (method.getModifiers()
57: .contains("static")) {
58: context.reportViolation(method);
59: }
60: }
61: }
62: }
63: }
64: } catch (JselException e) {
65: context.warn(clazz, e);
66: }
67: }
68: }
|