01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.Code;
28: import com.pavelvlasov.jsel.LanguageElement;
29: import com.pavelvlasov.jsel.Method;
30: import com.pavelvlasov.jsel.expressions.MethodCall;
31: import com.pavelvlasov.review.SourceMarker;
32:
33: /**
34: * ER-086
35: * Avoid calling 'finalize ()' explicitly
36: * @author Janos Czako
37: * @version $Revision: 1.4 $
38: */
39: public class InvokeFinalizeRule extends InspectorBase {
40:
41: private static final String FINALIZE = "finalize(";
42:
43: public void visit(MethodCall element) {
44: String method = element.toString();
45:
46: if (FINALIZE.equals(method) || method.endsWith("." + FINALIZE)) {
47: if ("super.finalize(".equals(method)) {
48: Code code = ((LanguageElement) element)
49: .getEnclosingCode();
50: if (code instanceof Method
51: && ((Method) code).getParameters().isEmpty()
52: && "finalize".equals(((Method) code).getName())) {
53: return;
54: }
55: }
56: context.reportViolation((SourceMarker) element);
57: }
58: }
59:
60: }
|