01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import java.util.Collections;
26: import java.util.Iterator;
27: import java.util.LinkedList;
28: import java.util.List;
29:
30: import org.hammurapi.InspectorBase;
31:
32: import com.pavelvlasov.jsel.Field;
33:
34: /**
35: *
36: * @author Pavel Vlasov
37: * @version $Revision: 1.2 $
38: */
39: public class ModifiersOrderRule extends InspectorBase {
40: public static final List modifiers;
41:
42: static {
43: List mdf = new LinkedList();
44: mdf.add("public");
45: mdf.add("protected");
46: mdf.add("private");
47: mdf.add("abstract");
48: mdf.add("static");
49: mdf.add("final");
50: mdf.add("synchronized");
51: mdf.add("native");
52: mdf.add("transient");
53: mdf.add("volatile");
54: mdf.add("strictfp");
55: modifiers = Collections.unmodifiableList(mdf);
56: }
57:
58: public void visit(Field field) {
59: int prevIdx = -1;
60: Iterator it = field.getModifiers().iterator();
61: while (it.hasNext()) {
62: int idx = modifiers.indexOf(it.next());
63: if (idx < prevIdx) {
64: context.reportViolation(field);
65: break;
66: }
67: prevIdx = idx;
68: }
69: }
70: }
|