01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.expressions.MethodCall;
28: import com.pavelvlasov.review.SourceMarker;
29:
30: /**
31: * ER-104
32: * Do not use 'notify ()'; use 'notifyAll ()' instead
33: * @author Pavel Vlasov
34: * @version $Revision: 1.2 $
35: */
36: public class NotifyRule extends InspectorBase {
37:
38: /**
39: * The name of the notify() method.
40: */
41: private static final String NOTIFY = "notify";
42:
43: /**
44: * Reviews the methodcalls, if they are notify() and so violate agains the
45: * rule.
46: *
47: * @param element the methodcall to be reviewed.
48: */
49: public void visit(MethodCall element) {
50: if (NOTIFY.compareTo(element.getName().toString()) == 0) {
51: if (element.getParameters().size() == 0) {
52: context.reportViolation((SourceMarker) element);
53: }
54: }
55: }
56:
57: }
|