01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.LanguageElement;
28: import com.pavelvlasov.jsel.expressions.Expression;
29: import com.pavelvlasov.jsel.expressions.Parenthesis;
30: import com.pavelvlasov.review.SourceMarker;
31:
32: /**
33: * @author Pavel Vlasov
34: * @version $Revision: 1.5 $
35: */
36: public class RedundantParenthesisRule extends InspectorBase {
37:
38: public void visit(Parenthesis parenthesis) {
39: if (parenthesis.getOperands().isEmpty()) {
40: return;
41: }
42:
43: Class parent = ((LanguageElement) parenthesis).getParent()
44: .getClass();
45: if (parent.getInterfaces().length == 0) {
46: return;
47: }
48: parent = parent.getInterfaces()[0];
49: if (parent.getInterfaces().length == 0) {
50: return;
51: }
52: parent = parent.getInterfaces()[0];
53:
54: Expression firstOperand = parenthesis.getOperand(0);
55: Class operand = firstOperand.getClass();
56: if (operand.getInterfaces().length == 0) {
57: return;
58: }
59: operand = operand.getInterfaces()[0];
60: if (operand.getInterfaces().length == 0) {
61: return;
62: }
63: operand = operand.getInterfaces()[0];
64:
65: if (parent.isAssignableFrom(operand)) {
66: context.reportViolation((SourceMarker) parenthesis);
67: }
68: }
69: }
|