01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.Field;
28: import com.pavelvlasov.jsel.JselException;
29: import com.pavelvlasov.jsel.VariableDefinition;
30:
31: /**
32: * ER-087
33: * Avoid "static" collections; they can grow without bounds
34: * @author Janos Czako
35: * @version $Revision: 1.2 $
36: */
37: public class StaticCollectionsRule extends InspectorBase {
38:
39: /**
40: * static Collection attribute is a violation
41: */
42: private static final String STATIC = "static";
43:
44: /**
45: * Reviews the type definition, if it has static Collection attributes.
46: *
47: * @param type the type definition to be reviewed.
48: */
49: public void visit(com.pavelvlasov.jsel.Class clazz) {
50: java.util.Iterator iter = clazz.getFields().iterator();
51:
52: while (iter.hasNext()) {
53: Field field = (Field) iter.next();
54: if (field instanceof VariableDefinition
55: && field.getModifiers().contains(STATIC)) {
56: VariableDefinition vd = (VariableDefinition) field;
57: try {
58: if (vd.getTypeSpecification().getType().isKindOf(
59: "java.util.Collection")) {
60: context.reportViolation(field);
61: }
62: } catch (JselException e) {
63: context.warn(field, e);
64: }
65: }
66: }
67: }
68: }
|