01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.LanguageElement;
28: import com.pavelvlasov.jsel.statements.BreakStatement;
29: import com.pavelvlasov.jsel.statements.CasesGroup;
30: import com.pavelvlasov.jsel.statements.ReturnStatement;
31: import com.pavelvlasov.jsel.statements.ThrowStatement;
32:
33: /**
34: * ER-027
35: * Switch statement case without 'break'
36: * @author Janos Czako
37: * @version $Revision: 1.3 $
38: */
39: public class SwitchCaseBreakRule extends InspectorBase {
40:
41: /**
42: * Reviews the the switch case if it contains a break as it's
43: * last statement.
44: *
45: * @param element the case to be reviewed
46: */
47: public void visit(CasesGroup element) {
48: java.util.Iterator statements = element.getStatements()
49: .iterator();
50: LanguageElement le = null;
51: while (statements.hasNext()) {
52: le = (LanguageElement) statements.next();
53: }
54: // Last statement must be break, throw or return
55: if (!(le instanceof BreakStatement
56: || le instanceof ThrowStatement || le instanceof ReturnStatement)) {
57: context.reportViolation(element);
58: }
59: }
60: }
|