01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.JselException;
28: import com.pavelvlasov.jsel.OperationNameSpace.OperationNameSpaceEntry;
29:
30: /**
31: * ER-116
32: * Use the "synchronized" modifier on methods that implement 'Runnable.run ()'
33: * @author Janos Czako
34: * @version $Revision: 1.2 $
35: */
36: public class SynchronizedRunnableRunMethodRule extends InspectorBase {
37:
38: public void visit(com.pavelvlasov.jsel.Class clazz) {
39: try {
40: if (clazz.isKindOf("java.lang.Runnable")) {
41: OperationNameSpaceEntry entry = clazz
42: .getOperationNamespace().find("run()");
43: if (entry != null
44: && !entry.getInfo().getModifiers().contains(
45: "synchronized")
46: && clazz.getName().equals(
47: entry.getInfo().getDeclaringType()
48: .getName())) {
49: context.reportViolation(clazz);
50: }
51: }
52: } catch (JselException e) {
53: context.warn(clazz, e);
54: }
55: }
56: }
|