01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.JselException;
28: import com.pavelvlasov.jsel.LanguageElement;
29: import com.pavelvlasov.jsel.TypeSpecification;
30: import com.pavelvlasov.jsel.VariableDefinition;
31: import com.pavelvlasov.jsel.expressions.Ident;
32: import com.pavelvlasov.jsel.expressions.StringConstant;
33: import com.pavelvlasov.jsel.statements.CasesGroup;
34:
35: /**
36: * ER-101
37: * Avoid using text labels in "switch" statements
38: * @author Janos Czako
39: * @version $Revision: 1.2 $
40: */
41: public class TextLabelsInSwitchStatementRule extends InspectorBase {
42:
43: /**
44: * Type name for String.
45: */
46: private static final String STRING_TYPE = "java.lang.String";
47:
48: /**
49: * Reviews the cases of the switch statements, if they have String labels.
50: *
51: * @param element the case to be reviewed.
52: */
53: public void visit(CasesGroup element) {
54: java.util.Iterator iter = element.getCases().iterator();
55: while (iter.hasNext()) {
56: LanguageElement le = (LanguageElement) iter.next();
57: if (le instanceof StringConstant) {
58: context.reportViolation(le);
59: } else if (le instanceof Ident) {
60: try {
61: Object r = le.getEnclosingScope()
62: .getVariableNamespace().find(
63: ((Ident) le).getText())
64: .getTypeName();
65: if (r instanceof VariableDefinition) {
66: VariableDefinition vd = (VariableDefinition) r;
67: TypeSpecification typeSpecification = vd
68: .getTypeSpecification();
69:
70: if (STRING_TYPE.equals(typeSpecification
71: .getName())) {
72: context.reportViolation(le);
73: }
74: }
75: } catch (JselException e) {
76: context.warn(element, e);
77: }
78: }
79: }
80: }
81: }
|