01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.JselException;
28: import com.pavelvlasov.jsel.LanguageElement;
29: import com.pavelvlasov.jsel.OperationInfo;
30: import com.pavelvlasov.jsel.expressions.MethodCall;
31: import com.pavelvlasov.review.SourceMarker;
32:
33: /**
34: * ER-106
35: * Avoid using 'Thread.yield'
36: * @author Pavel Vlasov
37: * @version $Revision: 1.2 $
38: */
39: public class ThreadYieldRule extends InspectorBase {
40:
41: /**
42: * yield belongs to this class
43: */
44: private static final String VIOLATION_CLASS = "java.lang.Thread";
45:
46: /**
47: * The method yield is the subject of this rule.
48: */
49: private static final String VIOLATION_METHOD = "yield";
50:
51: /**
52: * Reviews the methodcalls to yield, since they are violations.
53: *
54: * @param element the methodcall to be reviewed.
55: */
56: public void visit(MethodCall element) {
57: try {
58: OperationInfo provider = element.getProvider();
59: if (provider == null) {
60: context.warn((SourceMarker) element,
61: "Provider is null for "
62: + element
63: + " at "
64: + ((LanguageElement) element)
65: .getLocation());
66: } else if (VIOLATION_METHOD.equals(provider.getName())
67: && provider.getParameterTypes().length == 0
68: && provider.getDeclaringType().isKindOf(
69: VIOLATION_CLASS)) {
70: context.reportViolation((SourceMarker) element);
71: }
72: } catch (JselException e) {
73: context.warn((SourceMarker) element, e);
74: }
75: }
76:
77: }
|