01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.VariableDefinition;
28: import com.pavelvlasov.jsel.impl.AST;
29: import com.pavelvlasov.jsel.statements.ForStatement;
30:
31: /**
32: * ER-023
33: * Variables should be declared in individual statements.
34: * @author Pavel Vlasov
35: * @version $Revision: 1.5 $
36: */
37: public class VariablesRule extends InspectorBase {
38:
39: public void visit(VariableDefinition element) {
40: AST node = element.getAst();
41: AST prevNode = (AST) node.getPrevSibling();
42: if (prevNode != null
43: && !(element.getParent() instanceof ForStatement)
44: && "VARIABLE_DEF".equals(prevNode.getTypeName())
45: && node.getLine() == prevNode.getLine()
46: && node.getColumn() == prevNode.getColumn()) {
47: context.reportViolation(element);
48: }
49: }
50:
51: }
|