01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.VariableDefinition;
28: import com.pavelvlasov.jsel.impl.AST;
29:
30: /**
31: * ER-018
32: * Array declarators should be placed next to the type, not the variable name
33: * @author Pavel Vlasov
34: * @version $Revision: 1.4 $
35: */
36: public class ArrayDeclarationRule extends InspectorBase {
37:
38: /**
39: * @param element
40: */
41: public void visit(VariableDefinition element) {
42: AST arrayNode = null;
43: AST identNode = null;
44:
45: for (AST node = (AST) element.getAst().getFirstChild(); node != null; node = (AST) node
46: .getNextSibling()) {
47: String typeName = node.getTypeName();
48: if ("TYPE".equals(typeName)) {
49: AST node2 = (AST) node.getFirstChild();
50: if (node2 != null
51: && "ARRAY_DECLARATOR".equals(node2
52: .getTypeName())) {
53: arrayNode = node2;
54: }
55: } else if ("IDENT".equals(typeName)) {
56: identNode = node;
57: break;
58: }
59: }
60:
61: if (arrayNode != null && identNode != null
62: && identNode.getColumn() < arrayNode.getColumn()) {
63: context.reportViolation(element);
64: }
65: }
66: }
|