01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import java.util.HashSet;
26: import java.util.Iterator;
27: import java.util.Set;
28:
29: import org.hammurapi.InspectorBase;
30:
31: import com.pavelvlasov.jsel.CompilationUnit;
32: import com.pavelvlasov.jsel.Identifier;
33: import com.pavelvlasov.jsel.JselException;
34: import com.pavelvlasov.review.SourceMarker;
35:
36: /**
37: * Duplicate import declaration
38: * @author Pavel Vlasov
39: * @version $Revision: 1.2 $
40: */
41: public class DuplicateImportRule extends InspectorBase {
42:
43: /**
44: * Reviews the compilation unit (Java source file) for duplicated import
45: * statements.
46: *
47: * @param compilationUnit the unit to be reviewed.
48: * @throws JselException error by parsing the unit.
49: */
50: public void visit(CompilationUnit compilationUnit)
51: throws JselException {
52: Set imports = new HashSet();
53: Iterator it = compilationUnit.getImports().iterator();
54: while (it.hasNext()) {
55: Identifier id = (Identifier) it.next();
56: if (!imports.add(id.getValue())) {
57: context.reportViolation((SourceMarker) id);
58: }
59: }
60: }
61: }
|