01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.statements.DoStatement;
28: import com.pavelvlasov.jsel.statements.ForStatement;
29: import com.pavelvlasov.jsel.statements.IfStatement;
30: import com.pavelvlasov.jsel.statements.WhileStatement;
31: import com.pavelvlasov.review.SourceMarker;
32:
33: /**
34: * ER-097
35: * Avoid "for", "do", "while", "if" and "if ... else" statements with empty bodies
36: * @author Pavel Vlasov
37: * @version $Revision: 1.2 $
38: */
39: public class EmptyBodiesRule extends InspectorBase {
40:
41: public void visit(ForStatement element) {
42: if (isEmpty(element.getStatement())) {
43: context.reportViolation((SourceMarker) element);
44: }
45: }
46:
47: public void visit(DoStatement element) {
48: if (isEmpty(element.getStatement())) {
49: context.reportViolation((SourceMarker) element);
50: }
51: }
52:
53: public void visit(WhileStatement element) {
54: if (isEmpty(element.getStatement())) {
55: context.reportViolation((SourceMarker) element);
56: }
57: }
58:
59: public void visit(IfStatement element) {
60: if (isEmpty(element.getStatement())) {
61: context.reportViolation((SourceMarker) element);
62: }
63: }
64: }
|