01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.JselException;
28: import com.pavelvlasov.jsel.Parameter;
29: import com.pavelvlasov.jsel.expressions.AssignmentExpression;
30: import com.pavelvlasov.jsel.expressions.ConditionalExpression;
31: import com.pavelvlasov.jsel.expressions.Ident;
32: import com.pavelvlasov.jsel.expressions.LogicalOr;
33: import com.pavelvlasov.review.SourceMarker;
34:
35: /**
36: * @author Pavel Vlasov
37: *
38: * @version $Revision: 1.2 $
39: */
40: public class ParameterAssignmentInspector extends InspectorBase {
41:
42: public void visit(AssignmentExpression expr) {
43: try {
44: if (!(expr instanceof LogicalOr)
45: && !(expr instanceof ConditionalExpression)) {
46: Object firstOperand = expr.getOperand(0);
47: if ((firstOperand instanceof Ident)
48: && ((Ident) firstOperand).getProvider() instanceof Parameter) {
49: context.reportViolation((SourceMarker) expr);
50: }
51: }
52: } catch (JselException e) {
53: context.warn((SourceMarker) expr, e);
54: }
55: }
56:
57: }
|