01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import java.util.Collections;
26: import java.util.HashSet;
27: import java.util.Set;
28:
29: import org.hammurapi.InspectorBase;
30:
31: import com.pavelvlasov.jsel.VariableDefinition;
32:
33: /**
34: * ER-091
35: * Avoid using "public static final" array fields
36: * @author Janos Czako
37: * @version $Revision: 1.2 $
38: */
39: public class PublicStaticArrayFieldsRule extends InspectorBase {
40:
41: private static final Set modifiers;
42:
43: static {
44: HashSet mf = new HashSet();
45: mf.add("public");
46: mf.add("static");
47: mf.add("final");
48: modifiers = Collections.unmodifiableSet(mf);
49: }
50:
51: /**
52: * Reviews the type definitions, if they have public static final
53: * array attributes.
54: *
55: * @param element the type to be reviewed.
56: */
57: public void visit(VariableDefinition element) {
58: if (element.getModifiers().containsAll(modifiers)
59: && element.getTypeSpecification().getDimensions() > 0) {
60: context.reportViolation(element);
61: }
62: }
63:
64: }
|