01: /*
02: * * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.JselException;
28: import com.pavelvlasov.jsel.LanguageElement;
29: import com.pavelvlasov.jsel.TypeDefinition;
30: import com.pavelvlasov.jsel.VariableDefinition;
31:
32: /**
33: * @author MUCBJ0
34: * @author Pavel Vlasov.
35: *
36: * FIX 1: changed package name from org.apache.struts.actions.Action to org.apache.struts.action.Action
37: */
38: public class StatelessStrutsAction extends InspectorBase {
39:
40: public boolean isOfInterest(VariableDefinition element)
41: throws JselException {
42: LanguageElement parent = element.getParent();
43: if (parent instanceof TypeDefinition) {
44: return ((TypeDefinition) parent)
45: .isKindOf("org.apache.struts.action.Action");
46: } else {
47: return false;
48: }
49: }
50:
51: public void visit(VariableDefinition element) {
52: try {
53: if (isOfInterest(element)
54: && !(/*element.getModifiers().contains("static") || */element
55: .getModifiers().contains("final"))) {
56: context.reportViolation(element);
57: }
58: } catch (JselException e) {
59: context.warn(element.getEnclosingType(), e);
60: }
61: }
62:
63: }
|