01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23:
24: package org.hammurapi.inspectors;
25:
26: import java.util.Iterator;
27:
28: import org.hammurapi.InspectorBase;
29:
30: import com.pavelvlasov.jsel.statements.CasesGroup;
31: import com.pavelvlasov.jsel.statements.DefaultCase;
32: import com.pavelvlasov.jsel.statements.Statement;
33: import com.pavelvlasov.jsel.statements.SwitchStatement;
34: import com.pavelvlasov.review.SourceMarker;
35:
36: /**
37: *
38: * @author Pavel Vlasov
39: * @version $Revision: 1.2 $
40: */
41: public class SwitchDefaultRule extends InspectorBase {
42:
43: /**
44: * Reviews the switch statement.
45: *
46: * @param statement the statement to review.
47: */
48: public void visit(SwitchStatement statement) {
49: Iterator it = statement.getCasesGroups().iterator();
50: while (it.hasNext()) {
51: CasesGroup group = (CasesGroup) it.next();
52: Iterator cit = (group).getCases().iterator();
53: while (cit.hasNext()) {
54: if (cit.next() instanceof DefaultCase) {
55: Iterator sit = group.getStatements().iterator();
56: while (sit.hasNext()) {
57: if (!isEmpty((Statement) sit.next())) {
58: return;
59: }
60: }
61: context.reportViolation((SourceMarker) statement,
62: "Default case is present but empty");
63: return;
64: }
65: }
66: }
67: context.reportViolation((SourceMarker) statement);
68: }
69: }
|