01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.JselException;
28: import com.pavelvlasov.jsel.LanguageElement;
29: import com.pavelvlasov.jsel.Repository;
30: import com.pavelvlasov.jsel.expressions.MethodCall;
31: import com.pavelvlasov.jsel.expressions.This;
32:
33: /**
34: * ER-083
35: * Avoid passing the "this" reference as an argument
36: * @author Janos Czako
37: * @version $Revision: 1.2 $
38: */
39: public class ThisReferenceAsArgumentInEjbRule extends InspectorBase {
40:
41: /**
42: * The full qualified name of the class javax.ejb.EnterpriseBean.
43: */
44: private static final String EB_CLASS_NAME = "javax.ejb.EnterpriseBean";
45:
46: /**
47: * Visits the methodcalls if they has this as parameter.
48: *
49: * @param element the methodcall to be reviewed.
50: */
51: public void visit(MethodCall element) {
52: LanguageElement lelement = ((LanguageElement) element);
53: Repository repository = lelement.getCompilationUnit()
54: .getPackage().getRepository();
55:
56: try {
57: if (((LanguageElement) element).getEnclosingType()
58: .isKindOf(EB_CLASS_NAME)) {
59: java.util.Iterator iter = element.getParameters()
60: .iterator();
61: while (iter.hasNext()) {
62: if (iter.next() instanceof This) {
63: context.reportViolation(lelement);
64: }
65: }
66: }
67: } catch (JselException e) {
68: context.warn(lelement, e);
69: }
70: }
71:
72: }
|