01: /*
02: * Hammurapi
03: * Automated Java code review system.
04: * Copyright (C) 2004 Hammurapi Group
05: *
06: * This program is free software; you can redistribute it and/or modify
07: * it under the terms of the GNU General Public License as published by
08: * the Free Software Foundation; either version 2 of the License, or
09: * (at your option) any later version.
10: *
11: * This program is distributed in the hope that it will be useful,
12: * but WITHOUT ANY WARRANTY; without even the implied warranty of
13: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14: * GNU General Public License for more details.
15: *
16: * You should have received a copy of the GNU General Public License
17: * along with this program; if not, write to the Free Software
18: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19: *
20: * URL: http://www.hammurapi.org
21: * e-Mail: support@hammurapi.biz
22: */
23: package org.hammurapi.inspectors;
24:
25: import org.hammurapi.InspectorBase;
26:
27: import com.pavelvlasov.jsel.JselException;
28: import com.pavelvlasov.jsel.Method;
29:
30: /**
31: * ER-124
32: * Instance variables and method names shouldn't have same name
33: * @author Janos Czako
34: * @version $Revision: 1.2 $
35: */
36: public class VariablesAndMethodsNameClashingRule extends InspectorBase {
37:
38: /**
39: * Reviews the type definitions, if they have clashing names among
40: * the class attributes and the methods.
41: *
42: * @param element the type definition to be reviewed.
43: */
44: public void visit(Method element) {
45: try {
46: if (element.getEnclosingScope().getVariableNamespace()
47: .find(element.getName()) != null) {
48: context.reportViolation(element);
49: }
50: } catch (JselException e) {
51: context.warn(element, e);
52: }
53: }
54:
55: }
|